Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forecasting sdk and environment changes #3381

Merged
merged 7 commits into from
Nov 16, 2022
Merged

Forecasting sdk and environment changes #3381

merged 7 commits into from
Nov 16, 2022

Conversation

simmonsj330
Copy link
Contributor

@simmonsj330 simmonsj330 commented Nov 11, 2022

Description

Updating conda-3-9-env-full.yml to use u8darts instead of u8darts[torch] because they point to the same conda-forge source (this fixes #3348). Additionally, fixing dependency version issues which were identified when creating a new environment with forecasting and installing the sdk. Lastly, updating the SDK_README.md to demonstrate the proper way to create an environment if the user would like to utilize forecasting features.

Working forecasting menu installed by created an environment with conda create -n <environment> -c conda-forge python=3.9.6 u8darts=0.22.0 pytorch-lightning=1.6.5 -y
Screen Shot 2022-11-10 at 9 57 53 PM

Only one pre-commit issue was flagged but it is acceptable because it is related to an example secret in SDK_README.md
Screen Shot 2022-11-10 at 9 48 34 PM

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@simmonsj330 simmonsj330 added bug Fix bug platform OpenBB Platform labels Nov 11, 2022
@simmonsj330 simmonsj330 self-assigned this Nov 11, 2022
@jmaslek
Copy link
Collaborator

jmaslek commented Nov 15, 2022

@martinb-bb/ @Lukazcreations is this good?

@reviewpad reviewpad bot added the feat XS Extra small feature label Nov 15, 2022
@martinb-ai
Copy link
Contributor

@simmonsj330 ^^ please check the update i just made to the reqs.txt to make sure that protobuf version doesn't break anything

@simmonsj330 simmonsj330 merged commit 418fef5 into main Nov 16, 2022
@simmonsj330 simmonsj330 deleted the fc_poetry branch November 16, 2022 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug feat XS Extra small feature platform OpenBB Platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Pip install statsforecast dependency numba conflict
3 participants