-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring econometrics for SDK usability #3379
Conversation
There are a couple functions that need some cleaning up for the sdk, but if anyone wants to review this overnight feel free :) |
Thank you <3 |
I just have |
c87ebcc
to
09831cc
Compare
Make sure by the way that if you do |
Ummm that's the desired behavior to print the nice charts when chart = True. Doing otherwise would be a whole refactor. |
Just making sure we don't mean different things, I mean that if you use Whereas this screenshot also shows the Rich table. That looks wrong. |
Not possible with the current architecture. |
Ok ok |
The rich table shouldn't be an option in the first place, you can rely on the default output (without |
I think this gets into the question of the default output. In this menu its primarily tables so we want raw=True by default. You can actually pass plot=False in these cases. So I think its a matter of what the default output is |
If you are in a script, you wouldnt get the default output and could instead see a table with view. So if you want the default output, dont use the _view. |
The econometrics menu is nice, but the SDK usage is not friendly because how we do it in the terminal. This menu needs some refactoring so that the SDK is usable. Still love you @JerBouma.
Things done:
Refactor OLS so that the SDK can take in dataframes instead of a dictionary of dataframes: This will do fixes [Bug] SDK -
openbb.econometrics.ols
displays more objects than feasible #3368 fixes [Bug] SDK -openbb.econometrics.ols
requires dictionary datasets instead of DataFrames #3367 fixes [IMPROVE] SDK -openbb.econometrics.ols
input can be much nicer #3369Fixes [Bug] SDK -
openbb.econometrics.norm
should produce a chart #3366 by making chart=True by defaultFixes [Bug] SDK -
openbb.econometrics.coint
is messy and you can't plot anything #3373 by refactoring the coint function to return a df only. I also changed it to allow a variable number of inputs in the sdk and allowing for the plot to show up when doing chart=TrueFixes [Bug] SDK -
openbb.econometrics.granger
returns a messy output #3370 and fixes [Bug] SDK -openbb.econometrics.granger
- Error: get_granger_causality() missing 1 required positional argument: 'lags' #3323 for the granger SDK functionRefactor dwat function to take in an OLS model instead of the residuals. I think this cleans up. Made a note about the view in the model docstring
Complete the fixes [Bug] SDK -
openbb.econometrics.dwat
,openbb.econometrics.bgod
andopenbb.econometrics.bpag
can't be used #3372 -- sdk functions now input modelsRefactor panel. Fixes [Bug] SDK -
openbb.econometrics.panel
shows the same thing twice #3374