Remove mockings #3378
Merged
Remove mockings #3378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chavithra
reviewed
Nov 10, 2022
Chavithra
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to remove the function
openbb_terminal/core/log/generation/formatter_with_exceptions.mock_break_lines.In the way logging is working at the moment, there is no real benefit on having this function, since the logs that depend on the user input are already addressed by:
openbb_terminal/parent_classes.log_cmd_and_queueandopenbb_terminal/core/library/operation.__log_method_info--> usingjson.dumpsensure the string is in a valid json format.Also, by changing the
\s in an already valid json string we take the risk of making the json string invalid thus, eventually affecting the ETL pipeline or the queries - that expect a well-formed json string.