Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stock Integrated Tests #3353

Merged
merged 10 commits into from
Nov 9, 2022
Merged

Stock Integrated Tests #3353

merged 10 commits into from
Nov 9, 2022

Conversation

colin99d
Copy link
Contributor

@colin99d colin99d commented Nov 9, 2022

Description

Fixes #3331

Makes the following changes:

  • in options_controller.py added error handling in update_runtime_choices
  • Updating incorrect type returned from options/yfinance_mode.py function get_option_chain
  • Fixed capitalization of Open in technical_analysis/volume_model.py
  • Gave options plotting common sense defaults, but also handled nonsense inputs.
  • Added error handling to screener, it looks like a bunch of the screeners don't work with historical, is that already known or a new issue?

Note: This only fixes the issues I could reproduce.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
    • python terminal.py "stocks/options/load aapl/exp 0/load spy/load NDX --source Nasdaq/exp 0 --source Nasdaq/chains --source Nasdaq"
    • python terminal.py "stocks/load gme/ta/load ionq -i 1/ad --open"
    • python terminal.py "stocks/options/load aapl/exp 0/plot"
    • python terminal.py "stocks/options/load aapl/exp 0/plot -x zzz -y zzz"
    • python terminal.py "stocks/scr/set top_losers/historical"
    • python terminal.py "stocks/load aapl --source Polygon/qa/beta"
  • Check any related reports
    • python terminal.py reports/equity TSLA

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@colin99d colin99d added the bug Fix bug label Nov 9, 2022
@colin99d colin99d marked this pull request as draft November 9, 2022 10:21
@colin99d colin99d requested a review from jmaslek November 9, 2022 10:49
@colin99d colin99d marked this pull request as ready for review November 9, 2022 12:24
@jmaslek jmaslek merged commit 6dea3a9 into main Nov 9, 2022
@jmaslek jmaslek deleted the stock_int_tests branch November 9, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Failures on stocks scripts
2 participants