Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3235
Currently the forex_helper uses the stocks_helper instead of calling yfinance on its own. This creates a lot of needless errors. I switched the forex_helper to just calling yf.download directly. This reduced the amount of code needed, and allows for all intervals to be called for yfinance.
Also makes the functionality to get the interval smarter for the SDK.
How has this been tested?
python terminal.py "forex/load USDHUF -i 3month"
python terminal.py "forex/load USDHUF -i 1day --source AlphaVantage"
openbb.forex.load("USD", "GBP", interval="1day")
python terminal.py reports/forex USDGBP
Checklist:
Others