-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix economy plot #3346
Merged
Merged
Fix economy plot #3346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmaslek
approved these changes
Nov 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of the change / bug fix. / Link # issue, if applicable.
Fix [Bug]
/economy/ $ plot --y1 T20YIE
#3347Fix [Bug] economy default report is broken #3413
call_fred
fred
andplot
by using a new functionfred_view.format_data_to_plot
- avoiding seeing different formatted plots.fred_model.get_aggregated_series_data
that adds readabilityfred_view.display_fred_series
that adds readability - also, removed the special case for when there was only oneseries_ids
being treated (if len(series_ids) == 1
) - so everything is handled the same waydataset_yaxis_1 = dataset_yaxis_1.dropna()
anddataset_yaxis_1 = dataset_yaxis_1.dropna()
toplot_view.show_plot
as if we combine multiple datasets (columns) without thisScreenshot of the feature or the bug before/after fix, if applicable.
Relevant motivation and context.
🐛 💀
List any dependencies that are required for this change.
NA
How has this been tested?
On a jupyter notebook:
(it was fixed a broken import)
On the terminal:
Checklist:
Others