crypto/ov/categories sort options
#3335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmaslek
reviewed
Nov 8, 2022
Comment on lines
140
to
145
| for c in [ | ||
| "Name", | ||
| "Market_Cap", | ||
| "Market_Cap_Change_24H", | ||
| "Top_3_Coins", | ||
| "Volume_24H", |
There was a problem hiding this comment.
Convention is to define this as a self.CATEGORY_SORT_CHOICES then use this here and in the choices
jmaslek
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3050 by adding correct table columns into the sort options.
How has this been tested?
Running pytest on
test_pycoingecko_view.pyandtest_overview_controller.pywith--rewrite-expecteddoes not change test results.Others