Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing crytpo/ov/stables bugs #3333

Merged
merged 5 commits into from
Nov 10, 2022

Conversation

simmonsj330
Copy link
Contributor

Description

Fixes #3035.

  • Addresses FutureWarning error.
  • Flip flops price_change_percentage_7d_in_currency and price_change_percentage_24h_in_currency
  • Fixes --descend issue
  • All other things noted in the bug seem to be non-issues

Correct sorting on 7 day and 24 hour change
Screen Shot 2022-11-07 at 4 11 20 PM

Change to sort options to match table better
Screen Shot 2022-11-07 at 4 12 28 PM

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@simmonsj330 simmonsj330 added bug Fix bug crypto Crypto related labels Nov 7, 2022
@simmonsj330 simmonsj330 self-assigned this Nov 7, 2022
Comment on lines 148 to 155
for c in [
"Symbol",
"Name",
"Price_[$]",
"Market_Cap_[$]",
"Market_Cap_Rank",
"Change_7d_[%]",
"Change_24h_[%]",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be a self.STABLES_STABLES_SORT or something

@jmaslek jmaslek merged commit 7bc2160 into OpenBB-finance:main Nov 10, 2022
@simmonsj330 simmonsj330 deleted the cgstables_bug_fix branch November 10, 2022 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug crypto Crypto related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] crypto/ov/cgstables various bugs
2 participants