Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding some test coverage #3316

Merged
merged 18 commits into from
Nov 9, 2022
Merged

Adding some test coverage #3316

merged 18 commits into from
Nov 9, 2022

Conversation

jmaslek
Copy link
Collaborator

@jmaslek jmaslek commented Nov 4, 2022

Not sure how far I will get before I head out but will update here

  • Our formatting tests were failing because futures called tickers instead of symbols so I changed that
  • Adding unit tests on economy macro -- which will help with making sure the csv countries are kept (note economy controller coverage was 48%). is now 54.
  • Added unit tests on fred from controller
  • Unit test on call index. Up to 65%
  • Unit test on call_treasury. 72% coverage on controller

@jmaslek jmaslek added the tests Test-related work label Nov 5, 2022
Copy link
Contributor

@andrewkenreich andrewkenreich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow what a coder - this guy is a UNIT

@jmaslek jmaslek merged commit f7d63fa into OpenBB-finance:main Nov 9, 2022
@jmaslek jmaslek deleted the coverage branch February 14, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Test-related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants