Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial commit - colin please fix tests #3309

Merged
merged 6 commits into from
Nov 9, 2022

Conversation

andrewkenreich
Copy link
Contributor

Description

#2984 - @colin99d will your write my tests for me pretty plsssss

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@andrewkenreich andrewkenreich linked an issue Nov 4, 2022 that may be closed by this pull request
@andrewkenreich andrewkenreich added the feat M Medium T-Shirt size feature label Nov 4, 2022
@jmaslek jmaslek merged commit 2911908 into main Nov 9, 2022
@jmaslek jmaslek deleted the 2984-improve-forexcandle-missing-lots-of-stuff branch November 9, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat M Medium T-Shirt size feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IMPROVE] forex/candle missing lots of stuff
4 participants