Refactored quote command #3304
Merged
Refactored quote command #3304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmaslek
reviewed
Nov 4, 2022
| from openbb_terminal.helper_funcs import print_rich_table | ||
|
|
||
|
|
||
| def display_quote(symbol: str) -> pd.DataFrame: |
jmaslek
reviewed
Nov 4, 2022
|
|
||
| quote_df = quote_df.set_index("Symbol") | ||
|
|
||
| quote_data = transpose(quote_df) |
There was a problem hiding this comment.
This would make me happier if you made this quote_df.T and get rid of the import
jmaslek
reviewed
Nov 4, 2022
|
|
||
|
|
||
| def load_quote(symbol: str) -> pd.DataFrame: | ||
| """Ticker quote. |
There was a problem hiding this comment.
Ticker quote [Source: YahooFInance]
|
Working in terminal and sdk!
|
jmaslek
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3053
Refactors the stocks/quote command to follow MVC, only adds the model to the SDK since the view just shows the same thing. The view would also have the same double showing issue since it needs to print and return the data.
How has this been tested?
python terminal.py stocks/quote aaplChecklist:
Others