-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugs] Fix 3255,3160 + Improved Terminal Version Check #3296
Conversation
def disable_matplotlib(): | ||
# We add this to avoid multiple figures being opened | ||
matplotlib.use("Agg") | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not following what the logic for this is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Matplotlib should be mocked ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The show is mocked it looks like, but just finished the tests with 70+ opened figures lol.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
boom boom
openbb.futures.historical
now correctly plots multiple tickersFix #3255
Added better logic for Terminal
check_for_updates
version check.stocks.load
/stocks.candle
now take datetime or "YYYY-MM-DD" forstart_date
andend_date
parameters for SDK callsFix #3160
updated git-actions set-output to new format
fixed
check_reserved_args
encoding issue and false positive onHistoryManager.hist_file
argadded disable_matplotlib to tests to avoid multiple figures being opened locally
Made strtobool function local as it is deprecated in Python 3.10
Description
How has this been tested?
Checklist:
Others