Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugs] Fix 3255,3160 + Improved Terminal Version Check #3296

Merged
merged 20 commits into from
Nov 9, 2022

Conversation

tehcoderer
Copy link
Contributor

@tehcoderer tehcoderer commented Nov 4, 2022

openbb.futures.historical now correctly plots multiple tickers

Fix #3255
image

Added better logic for Terminal check_for_updates version check.

image

stocks.load/stocks.candle now take datetime or "YYYY-MM-DD" for start_date and end_date parameters for SDK calls

Fix #3160
image

updated git-actions set-output to new format
fixed check_reserved_args encoding issue and false positive on HistoryManager.hist_file arg
added disable_matplotlib to tests to avoid multiple figures being opened locally
Made strtobool function local as it is deprecated in Python 3.10

Description

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@tehcoderer tehcoderer added bug Fix bug platform OpenBB Platform labels Nov 4, 2022
@tehcoderer tehcoderer changed the title Bug fixes [Bugs] Fix 3255,3160 + Improved Terminal Version Check Nov 4, 2022
@tehcoderer tehcoderer requested a review from piiq November 4, 2022 15:18
Comment on lines +354 to +357
def disable_matplotlib():
# We add this to avoid multiple figures being opened
matplotlib.use("Agg")

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not following what the logic for this is?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
It prevents this 🤣

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matplotlib should be mocked ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The show is mocked it looks like, but just finished the tests with 70+ opened figures lol.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I lied
image

Copy link
Contributor

@jose-donato jose-donato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

boom boom

@jmaslek jmaslek merged commit 721a7d5 into OpenBB-finance:main Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug platform OpenBB Platform
Projects
None yet
4 participants