SDK : faster and simpler architecture #3289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this mergeable? P.S. How do we import the sdk after this change? |
|
@montezdesousa @jmaslek this is ready imo, but since I was also pushing some commits, would be cool if one of you took a look at this! Tks! |
|
Also, @jmaslek we're keeping the |
noubre
pushed a commit
to noubre/OpenBBTerminal
that referenced
this pull request
Dec 13, 2022
* SDK : split features * Fix linting * SDK : remove functions * SDK : update openbb object building * SDK : comments * Typing * Typing * Typing * SDK : update logs * SDK : Breadcrumb * SDK : Breadcrumb + Operation * SDK : spell * Linting * Tests : SDK * SDK : Operation * SDK : Operation * Linting * enable wrong import position * added logging info * added log supression * reverted the order * SDK : update trail_map * log suppresion as configuration * changes reports to use the new sdk * changes dashboards to use the new sdk * changes dashboards to use the new sdk * updated the documentation * Tests + Linting * Replace old sdk by new sdk * Linting * SDK : import + map_dict * Linting * Linting * SDK : sdk + trail_map * Linting * SDK : forecasting * SDK : update import path * SDK * SDK : md * Linting * removed unused functions * trunc args to a max of 100 characters * added logging when exceptions * .md files * SDK : add signature on operation + linting + remove trail on Breadcrumb * Linting * Move tests * Linting * Linting * Linting * Linting * Linting * Linting * Linting Co-authored-by: Henrique Joaquim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the SDK contains different features:
All these parts are entangled, which makes it hard to check/change one specific part.
GOAL
This PR is meant to make code more team work friendly.
SIDE EFFECT
The loading time of the SDK is reduced.