-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Various portfolio/po issues #3286
Conversation
Much of the code is based on models from Riskfolio-lib. This is fine as we can expect the results to be accurate. However, the creator didn't follow our styling guide and wasn't the most experienced coder. So, ideally we would want to rewrite a lot of the code to improve it. I think this is relevant once we notice that there is a lot of interest from our target personas. |
Idk if this is an issue, but if I am in
|
This PR is a bandaid on a menu that needs a lot of refactoring. There are probably a lot of other bugs we do not know about as well, but until someone really takes the time to really fix it they will keep popping up. |
So the bug you addressed was the -f which is fixed. I tested all the edge cases I had with our previous auto complete issues, and it all worked. |
Description
Fixes #3135
-f
flag.tr
parameter to be an intplot
andrpf
Note: I am highly confident there are a lot more errors in this menu (it doesnt even follow MVC). And a lot of it is pretty hard to understand. However, this will take a lot of time so a decision like this goes to @Chavithra, @JerBouma, and @andrewkenreich.
How has this been tested?
python terminal.py portfolio/po/params/load OpenBB_Parameters_Template_v1.0.0.xlsx
(can load without -f)python terminal.py portfolio/po/params/load OpenBB_Parameters_Template_v1.0.0.xlsx/save colin.ini
(can save to new ath)python terminal.py "portfolio/po/load 50_30_10_10_Portfolio.xlsx/maxsharpe -p 1d" --debug
python terminal.py "portfolio/po/load 50_30_10_10_Portfolio.xlsx/maxsharpe"
then runmaxsharpe -h
python terminal.py "portfolio/po/load 50_30_10_10_Portfolio.xlsx/maxsharpe -tr 5"
(switched this argument to an integer)python terminal.py "portfolio/po/load 50_30_10_10_Portfolio.xlsx/maxsharpe -tr 5"
thenmaxsharpe -tr 3
thenmaxsharpe -tr 4
Checklist:
Others