-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Poetry : remove optional dependencies + set papermill 2.4.0 #3251
Conversation
@martinb-bb don't we still need torch? |
@colin99d Yes we need torch. |
@martinb-bb @colin99d it's from optional not from the extras. We still have [tool.poetry.extras]
prediction = ["torch"] |
Yes, but if torch is just there then it doesnt know what version to grab. |
If you want to make changes to poetry, please check if making a new environment works and installer builds before removing. We cannot afford more issues for building forecasting. |
Also, pyinstaller needs to remain as is in |
@Chavithra, closing this one without merge to create a new one that solely changes papermill and removes kaleido? |
…l into update_pyproject
Let me check forecast menu functionality with a new env before we merge this please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't forget to re-generate the requirements.txt files
Description
Here we update the content of these files:
pyproject.toml
poetry.lock
Change version:
Removing the following optional element from
pyproject.toml