Portfolio menu bug fixes

[montezdesousa]

Description

Fix issues mentioned here #3072, #3069, #3068

• This PR fixes [Bug] portfolio/bench - no autocompletion available for flag -b or --benchmark #3069
• Change orderbook references to transactions
• change load progress to something closer to tqdm for consistency with remaining terminal
• remove line between show and bench commands
• Fix Warning Please first define the portfolio (via 'load') and the benchmark (via 'bench').
• Fix var calculation
• var and es table values should be changed to % 2 decimals format
• Remove autocompletion for numbers that can take any value
• summary values are missing % symbol
• default sum to True in holdv and holdp. Remove total value from legend. See [IMPROVE] Redesign portfolio/holdv and portfolio/holdp #3121
• alloc assets -t tables have no spacing between them
• Message: Loading country/region data: shows up out of nowhere with alloc -a countries command
• Message: Loading sector data: shows up out of nowhere with alloc sectors
• mret --raw outputs 2 tables, one for benchmark, other for portfolio. Should be identified which is which in the title.
• remove limitation of having negative risk free rates

Checklist:

• Update our Hugo documentation following these guidelines.
• Update our tests following these guidelines.
• Make sure you are following our CONTRIBUTING guidelines.
• If a feature was added make sure to add it to the corresponding scripts file.

Others

• I have performed a self-review of my own code.
• I have commented my code, particularly in hard-to-understand areas.

[JerBouma]

Could you make sure that the rfr, as mentioned here #3074, is an actual percentage? E.g. 0.1 = 0.1%. It is undesirable you need to enter 0.001 to get 0.1% (and can be confusing to work with).

[hjoaquim]

In #3072 you mentioned:

Pull Metrics commands to before Graphs because this is what gives you a snapshot of your portfolio
Is this something to drop?

I've added this small commit that I think goes more according to the guidelines (only one empty line after the user input and before output, and also just 1 empty line separating each table).
Let me know if you agree with this.

Other than this, I think everything described is addressed and issues are gone.
No other remarks, very nice job on this!

[montezdesousa]

In #3072 you mentioned:

Pull Metrics commands to before Graphs because this is what gives you a snapshot of your portfolio
Is this something to drop?

I've added this small commit that I think goes more according to the guidelines (only one empty line after the user input and before output, and also just 1 empty line separating each table). Let me know if you agree with this.

Other than this, I think everything described is addressed and issues are gone. No other remarks, very nice job on this!

Thanks, yes I drop that one, bc I found it a bit subjective after all so I let it stay as it was. Looks good to me! Tks