Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker Volume Support and Remove the Last of the Files (Last Docker PR I Promise) #2715

Merged
merged 11 commits into from
Oct 6, 2022

Conversation

colin99d
Copy link
Contributor

@colin99d colin99d commented Oct 5, 2022

Description

Adds documentation so that users can easily create volumes for their docker stuff. Also @Chavithra is a big fan of deleting unused files, so I deleted some. If anyone wants them they will be in the git history FOREVER.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the api still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@colin99d colin99d added the docker Docker-related work label Oct 5, 2022
@colin99d colin99d marked this pull request as draft October 5, 2022 13:22
@colin99d colin99d marked this pull request as ready for review October 5, 2022 15:28
Copy link
Contributor

@Chavithra Chavithra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@colin99d colin99d merged commit 926508c into main Oct 6, 2022
@colin99d colin99d deleted the docker3 branch October 9, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Docker-related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants