Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleans plotting functionality for stocks/sia/metric #2713

Merged
merged 3 commits into from
Oct 5, 2022
Merged

Conversation

colin99d
Copy link
Contributor

@colin99d colin99d commented Oct 5, 2022

Description

Fixes #2712

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
    • python terminal.py "/stocks/load CS/sia/clear country/metric roa -l 20" --debug
  • Ensure the api still works (Command does not appear in API)
  • Check any related reports (Command does not appear in API)

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@colin99d colin99d added the bug Fix bug label Oct 5, 2022
@DidierRLopes DidierRLopes added the HACKTOBERFEST Hacktoberfest label Oct 5, 2022
@DidierRLopes DidierRLopes merged commit 6eb8a38 into main Oct 5, 2022
@colin99d colin99d deleted the fix_2712 branch October 9, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug HACKTOBERFEST Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Stocks/SIA/metric - Error: not enough values to unpack (expected 2, got 0) & also charting issue.
2 participants