-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace ln and ld by search #2710
Conversation
DidierRLopes
commented
Oct 4, 2022
- This fixes [IMPROVE] ETF replacing ld and ln by search #2542 2542
@Chavithra need a hand with the tests here pleaaseeee |
Hi Didier, The following code only work if you have space separated option/value, like required="-h" not in other_args
and "-n" not in other_args
and "--name" not in other_args, If you are using option/value like this |
Ohhh.. but that's how it was before. How was it working? 🤔 |
Like if you have `"--name=oil --source=FinanceDatabase", then: other_args = [
"--name=oil",
"--source=FinanceDatabse",
] So the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The etf/search
command works on my side.
I see now. That's smart. Nice catch, wouldn't have catch it that easily. Thanks @Chavithra |