Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace ln and ld by search #2710

Merged
merged 4 commits into from
Oct 5, 2022
Merged

replace ln and ld by search #2710

merged 4 commits into from
Oct 5, 2022

Conversation

DidierRLopes
Copy link
Collaborator

@DidierRLopes DidierRLopes added enhancement Enhancement HACKTOBERFEST Hacktoberfest labels Oct 4, 2022
@DidierRLopes
Copy link
Collaborator Author

@Chavithra need a hand with the tests here pleaaseeee

@Chavithra
Copy link
Contributor

Chavithra commented Oct 5, 2022

Hi Didier,

The following code only work if you have space separated option/value, like search --name oil --source FinanceDatabase:

            required="-h" not in other_args
            and "-n" not in other_args
            and "--name" not in other_args,

If you are using option/value like this search --name=oil --source=FinanceDatabase it will cease to work as expected.

@DidierRLopes
Copy link
Collaborator Author

Hi Didier,

The following code only work if you have space separated option/value, like search --name oil --source FinanceDatabase:

            required="-h" not in other_args
            and "-n" not in other_args
            and "--name" not in other_args,

If you are using option/value like this search --name=oil --source=FinanceDatabase it will cease to work as expected.

Ohhh.. but that's how it was before. How was it working? 🤔

@Chavithra
Copy link
Contributor

Like if you have `"--name=oil --source=FinanceDatabase", then:

 other_args = [
    "--name=oil",
    "--source=FinanceDatabse",
]

So the "--name" in other_args statement won't work.

Copy link
Contributor

@Chavithra Chavithra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The etf/search command works on my side.

@DidierRLopes
Copy link
Collaborator Author

Like if you have `"--name=oil --source=FinanceDatabase", then:

 other_args = [
    "--name=oil",
    "--source=FinanceDatabse",
]

So the "--name" in other_args statement won't work.

I see now. That's smart. Nice catch, wouldn't have catch it that easily. Thanks @Chavithra

@DidierRLopes DidierRLopes merged commit 20b6212 into main Oct 5, 2022
@colin99d colin99d deleted the etf branch October 9, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement HACKTOBERFEST Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IMPROVE] ETF replacing ld and ln by search
2 participants