Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add record session into routine capabiltiies #2702

Merged
merged 6 commits into from
Oct 4, 2022
Merged

Add record session into routine capabiltiies #2702

merged 6 commits into from
Oct 4, 2022

Conversation

DidierRLopes
Copy link
Collaborator

Screen.Recording.2022-10-04.at.00.36.20.mp4

@DidierRLopes DidierRLopes added feat S Small T-Shirt size Feature HACKTOBERFEST Hacktoberfest labels Oct 3, 2022
@colin99d
Copy link
Contributor

colin99d commented Oct 4, 2022

It would mean a lot to me if the command was q and you could name the macro with one letter.

@DidierRLopes
Copy link
Collaborator Author

It would mean a lot to me if the command was q and you could name the macro with one letter.

"q" is already used for quit unfortunately.

I can have just the command record to start and stop. What do you think?

For the macro being a single letter, we prob need a mapping from routine to macro. I can work on that in the future.

@colin99d
Copy link
Contributor

colin99d commented Oct 4, 2022

It would mean a lot to me if the command was q and you could name the macro with one letter.

"q" is already used for quit unfortunately.

I can have just the command record to start and stop. What do you think?

For the macro being a single letter, we prob need a mapping from routine to macro. I can work on that in the future.

Im sorry it was just a vim joke

@colin99d
Copy link
Contributor

colin99d commented Oct 4, 2022

@DidierRLopes. Maybe this is out of scope for this pr but when running the exe command should we remove the .openbb and just show test instead of test.openbb?

Copy link
Contributor

@colin99d colin99d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I bullied it, and it survived. Nice work!

@DidierRLopes DidierRLopes merged commit c268d85 into main Oct 4, 2022
@DidierRLopes
Copy link
Collaborator Author

@DidierRLopes. Maybe this is out of scope for this pr but when running the exe command should we remove the .openbb and just show test instead of test.openbb?

Probably I would leave the .openbb so that the user knows that the file needs to have that extension

@colin99d colin99d deleted the save branch October 9, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat S Small T-Shirt size Feature HACKTOBERFEST Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants