Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ec macro #2689

Merged
merged 26 commits into from
Oct 3, 2022
Merged

Fix ec macro #2689

merged 26 commits into from
Oct 3, 2022

Conversation

colin99d
Copy link
Contributor

@colin99d colin99d commented Oct 3, 2022

Description

Fixes #2686, and also changes code to remove future warnings.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
    • python terminal.py "economy/macro -t TOYA -p CPI -c Netherlands"
  • Ensure the api still works
    • openbb.economy.macro()
  • Check any related reports
    • python terminal.py reports/economy

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@colin99d colin99d requested a review from jmaslek October 3, 2022 07:20
@colin99d colin99d added the bug Fix bug label Oct 3, 2022
@colin99d colin99d merged commit 5f2360a into main Oct 3, 2022
@colin99d colin99d deleted the fix_ec_macro branch October 3, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Error loading economy/macro TOYA parameter
2 participants