-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved sorting capabilities in the news function #2682
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @colin99d, what do you think of moving the sort_values
inside the model instead? This way both model and view have the same output and api users have the sorted news dataframe with openbb.common.news(term="UK Pension fund")
Also can you can remove this line from api.py
virtual paths? -> "view": "openbb_terminal.common.feedparser_view.display_news"
Does not make sense to expose the view in the api in this case it just prints the news.
@montezdesousa. Updates made! |
tks! seems good to me! |
Description
Fixes #2681
How has this been tested?
Checklist:
Others