Bug/2583

[catalintoma]

Description

• Refactored denomination usages by using a common helper
• Fixed Yahoo Finance model not respecting 'thousands' denomination
• Fixed Yahoo Finance view not exporting raw data
• [Bug] Yahoo finance output in stocks/fa/income is not multiplying by 1000 #2583

How has this been tested?

• Added YF model tests
• Added tests for the denomination helper

Checklist:

• Update our tests following these guidelines.
• Make sure you are following our CONTRIBUTING guidelines.

Others

• I have performed a self-review of my own code.
• I have commented my code, particularly in hard-to-understand areas.

[catalintoma]

@DidierRLopes can you add the 'bug' label for this? If there is a way for me to set it on PR creation, please let me know to pay more attention.

I marked this as draft since I still want to improve the unit tests, but I am curious what you think about this approach. I've kind of wondered into to unknown with this with my limited Python skills, but felt there was room for refactoring all the places where we deal with converting denominations.

[colin99d]

Looks great so far! Nice work.

[DidierRLopes]

This is looking very nice @catalintoma ! Keep up the good work! 🤝

[catalintoma]

@colin99d
I've requested a review, I haven't seen anything else to fix.
Main refactoring's are around:

• Using helper for denomination transforms
• Fix YF model not returning raw data (numbers) and also not using correct 'thousands' denomination
• Fix YF view not exporting raw data

[colin99d]

Perfect! Will do later today.

[colin99d]

Great work man! Thanks for this pr.