Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix get_df for output in stocks/disc #2667

Merged
merged 4 commits into from
Sep 29, 2022
Merged

fix get_df for output in stocks/disc #2667

merged 4 commits into from
Sep 29, 2022

Conversation

gnzng
Copy link
Contributor

@gnzng gnzng commented Sep 29, 2022

Description

  • use manipulation of returned HTML string via regex to clean up yahoo HTML request. The radio button gives an extra 'Select TICKER' prompt (see screenshot)
  • import module re
  • replace whole class=\"Fz\(0\)\" span from HTML request

double_symbol

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

Tested functions on local machine in jupyter notebook with python 3.10.5 and pandas 1.4.3.

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the api still works
  • Check any related reports

solved

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@gnzng gnzng changed the title Update disc_helpers.py fix get_df for output in stocks/disc Sep 29, 2022
@colin99d colin99d self-requested a review September 29, 2022 09:40
@colin99d colin99d added the enhancement Enhancement label Sep 29, 2022
@colin99d
Copy link
Contributor

Thanks for this PR! Looks like linters need cleaned up and then we should be good to go.

@gnzng
Copy link
Contributor Author

gnzng commented Sep 29, 2022

I missed a whitespace after re import, will fix it in a second

@colin99d colin99d merged commit 30be17a into OpenBB-finance:main Sep 29, 2022
@colin99d
Copy link
Contributor

Great work man!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants