Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix charmap flair issue on windows #2664

Merged
merged 7 commits into from
Sep 30, 2022
Merged

Fix charmap flair issue on windows #2664

merged 7 commits into from
Sep 30, 2022

Conversation

colin99d
Copy link
Contributor

@colin99d colin99d commented Sep 29, 2022

Description

Is this still an issue? The test I wrote passed on Windows.
Fixes #2146

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the api still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@colin99d colin99d added the bug Fix bug label Sep 29, 2022
@colin99d colin99d marked this pull request as draft September 29, 2022 08:10
@colin99d colin99d marked this pull request as ready for review September 29, 2022 08:39
Copy link
Contributor

@Chavithra Chavithra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to me : the tests are working on my side.

@colin99d colin99d merged commit 79da5fd into main Sep 30, 2022
@colin99d colin99d deleted the fix_charmap branch September 30, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] flair - 'charmap' codec can't encode character
2 participants