Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stock and fund #2656

Merged
merged 5 commits into from
Sep 28, 2022
Merged

Fix stock and fund #2656

merged 5 commits into from
Sep 28, 2022

Conversation

colin99d
Copy link
Contributor

@colin99d colin99d commented Sep 28, 2022

Description

Fixes several integrated test bugs related to the stocks and fund menu. Just adds error handling.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the api still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@colin99d colin99d added the bug Fix bug label Sep 28, 2022
@hjoaquim hjoaquim self-requested a review September 28, 2022 13:24
Copy link
Contributor

@hjoaquim hjoaquim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost all tests pass now - the failures are being handled in a different PR.
Good job!

Funds:

image

Stocks:

image

@@ -413,6 +413,9 @@ def display_fundamentals(
fundamentals = yahoo_finance_model.get_financials(symbol, statement, ratios)
title_str = "Cash Flow Statement"

if fundamentals is None:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be added as an "OR" in line 418 "if", but I'm fine with this.

@colin99d colin99d merged commit 532daac into main Sep 28, 2022
@colin99d colin99d deleted the fix_stock_and_fund branch September 28, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants