Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes integrated tests for alt and economy #2655

Merged
merged 6 commits into from
Sep 28, 2022
Merged

Fixes integrated tests for alt and economy #2655

merged 6 commits into from
Sep 28, 2022

Conversation

colin99d
Copy link
Contributor

@colin99d colin99d commented Sep 28, 2022

Description

Fixes integrated tests in alt and economy.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the api still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@colin99d colin99d added the bug Fix bug label Sep 28, 2022
@montezdesousa
Copy link
Contributor

montezdesousa commented Sep 28, 2022

@colin99d I'm getting this behavior when -st is included. I believe -st was a deprecated flag to store the dataset, I don't see it in the help doc anymore. This is one of the integration tests, that's why I saw it. It's being catch by your try but the warning should not be related to dates.

image

@colin99d
Copy link
Contributor Author

@colin99d I'm getting this behavior when -st is included. I believe -st was a deprecated flag to store the dataset, I don't see it in the help doc anymore. This is one of the integration tests, that's why I saw it. It's being catch by your try but the warning should not be related to dates.

image

I think this is the desired behavior. Since the parser gets an argument of -s=t, then it cannot process that. While a proper date is sent, there is no way for argparse to know that, so instead of having it throw an error I print a warning.

@montezdesousa
Copy link
Contributor

@colin99d I'm getting this behavior when -st is included. I believe -st was a deprecated flag to store the dataset, I don't see it in the help doc anymore. This is one of the integration tests, that's why I saw it. It's being catch by your try but the warning should not be related to dates.
image

I think this is the desired behavior. Since the parser gets an argument of -s=t, then it cannot process that. While a proper date is sent, there is no way for argparse to know that, so instead of having it throw an error I print a warning.

Ok got it!

@montezdesousa montezdesousa merged commit 6c09428 into main Sep 28, 2022
@colin99d colin99d deleted the fix_alt2 branch October 4, 2022 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants