Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes integrated tests for the economy controller #2645

Merged
merged 5 commits into from
Sep 27, 2022
Merged

Fixes integrated tests for the economy controller #2645

merged 5 commits into from
Sep 27, 2022

Conversation

colin99d
Copy link
Contributor

@colin99d colin99d commented Sep 27, 2022

Description

Related to #2612
Fixes #2652

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the api still works (controllers do not affect API)
  • Check any related reports (controllers do not affect API)

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@colin99d colin99d added the bug Fix bug label Sep 27, 2022
@@ -661,7 +661,7 @@ def call_macro(self, other_args: List[str]):
transform=ns_parser.transform,
start_date=ns_parser.start_date,
end_date=ns_parser.end_date,
currency=ns_parser.currency,
symbol=ns_parser.currency,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is the design, but isn't symbol designated for what we are loading in, whether a fx pair or a ticker. In this case, currency tells us what the units are, which seems like a useful kwarg @minhhoang1023 ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IF anything, parameters should be symbol

@jmaslek jmaslek merged commit 72faca4 into main Sep 27, 2022
@colin99d colin99d deleted the economy_fix branch October 4, 2022 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] economy/macro unexpected keyword "currency"
2 participants