Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing crypto nft integration bug #2639

Merged
merged 3 commits into from
Sep 27, 2022

Conversation

simmonsj330
Copy link
Contributor

@simmonsj330 simmonsj330 commented Sep 27, 2022

Description

Fixes the crypto nft portion #2612 by truncating the created_date string to fit the criteria for the datetime function strptime since some nft data doesn't have milliseconds.

Screen Shot 2022-09-26 at 10 57 37 PM

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@simmonsj330 simmonsj330 added the bug Fix bug label Sep 27, 2022
@simmonsj330 simmonsj330 self-assigned this Sep 27, 2022
@colin99d colin99d self-requested a review September 27, 2022 04:49
Copy link
Contributor

@colin99d colin99d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API and terminal both work for me. Nice work!

@colin99d colin99d merged commit 6339d08 into OpenBB-finance:main Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants