Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pull_request_template.md #2631

Merged
merged 2 commits into from
Sep 26, 2022
Merged

Update pull_request_template.md #2631

merged 2 commits into from
Sep 26, 2022

Conversation

colin99d
Copy link
Contributor

@colin99d colin99d commented Sep 26, 2022

It can be easy to forget everything we need to do in testing. I added this simple checklist so that we forget less often. I also removed the last two items because these checks are automatically performed by the CI, so we can easily know if they have been performed.

Description

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

Just a markdown change, no need to test.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

It can be easy to forget everything we need to do in testing. I added this simple checklist so that we forget less often.
@colin99d colin99d added the docs Code documentation label Sep 26, 2022
@DidierRLopes DidierRLopes merged commit abb060f into main Sep 26, 2022
@colin99d colin99d deleted the colin99d-patch-1 branch October 4, 2022 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Code documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants