Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bad source default #2630

Merged
merged 3 commits into from
Sep 26, 2022
Merged

Fixed bad source default #2630

merged 3 commits into from
Sep 26, 2022

Conversation

colin99d
Copy link
Contributor

@colin99d colin99d commented Sep 26, 2022

Description

Fixes #2579

The source was defaulting to yahoo finance, which was not returning results. The API does not require a source, so for now I always send None. I personally do not see the value of being able to set the source, but if others feel its necessary I can add a parser argument. Users can still set the source in the API.

How has this been tested?

Ran command in terminal and api, ran pytest

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@colin99d colin99d added the bug Fix bug label Sep 26, 2022
@colin99d colin99d merged commit 2f57a92 into main Sep 26, 2022
@colin99d colin99d deleted the fix_crypto_news branch September 26, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Crypto/DD/news - Cannot find news for eth.
2 participants