Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration test fix for crypto disc #2625

Merged
merged 9 commits into from
Sep 28, 2022

Conversation

simmonsj330
Copy link
Contributor

Description

Fixes the crypto disc portion of #2612 by changing argument names to the correct ones. Particularly, changing the arguement name 'period' to 'interval' based off of the confluence page: Terminal analysis to create style guide.

Before
Screen Shot 2022-09-25 at 7 57 08 PM

After
Screen Shot 2022-09-25 at 7 56 55 PM

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@simmonsj330 simmonsj330 added the bug Fix bug label Sep 26, 2022
@simmonsj330 simmonsj330 self-assigned this Sep 26, 2022
Copy link
Contributor

@hjoaquim hjoaquim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine to me.
Runs with no issues indeed
image

@simmonsj330 simmonsj330 merged commit b2d570a into OpenBB-finance:main Sep 28, 2022
@simmonsj330 simmonsj330 deleted the test_crypto_disc_bug branch September 28, 2022 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants