Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing integration tests for crypto defi #2624

Merged
merged 8 commits into from
Sep 28, 2022
Merged

fixing integration tests for crypto defi #2624

merged 8 commits into from
Sep 28, 2022

Conversation

simmonsj330
Copy link
Contributor

@simmonsj330 simmonsj330 commented Sep 26, 2022 •
edited
Loading

Description

Fixes the crypto defi portion of #2612 by changing argument names to the correct ones.

Failing:
Screen Shot 2022-09-25 at 7 31 02 PM

Fixed:
Screen Shot 2022-09-25 at 7 26 19 PM

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@simmonsj330 simmonsj330 added the bug Fix bug label Sep 26, 2022
@simmonsj330 simmonsj330 self-assigned this Sep 26, 2022
@hjoaquim hjoaquim self-requested a review September 27, 2022 09:56
hjoaquim
hjoaquim approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@hjoaquim hjoaquim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine! Nice detail regarding the ascend/descend 🚀
No issues found after the fix:
image

@colin99d colin99d merged commit ef36c00 into OpenBB-finance:main Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjoaquim hjoaquim hjoaquim approved these changes

@Chavithra Chavithra Awaiting requested review from Chavithra

@minhhoang1023 minhhoang1023 Awaiting requested review from minhhoang1023

Assignees

@simmonsj330 simmonsj330

Labels
bug Fix bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@simmonsj330 @hjoaquim @colin99d @minhhoang1023