Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/2590 error setting exp #2615

Merged

Conversation

erlandsen-tech
Copy link
Contributor

@erlandsen-tech erlandsen-tech commented Sep 24, 2022

Description

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

I switched the fallback dataframe model from "Tradier" which requires a token, to YahooFinance that does not. In the event that a user of the terminal set expiry date without a source set, we got an error if token for tradier was faulty or not set. Therefore it makes more sense to have yahoo as the fallback dataframe for options. Another possible fix is to throw a console feedback where we tell the user to select a source before setting an expiry date.

How has this been tested?

Description of bug is given in issue #2590
testing have been done

Checklist:

Others

  • [x ] I have performed a self-review of my own code.
  • [x ] I have commented my code, particularly in hard-to-understand areas.
  • [x ] My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@DidierRLopes DidierRLopes added the bug Fix bug label Sep 24, 2022
Copy link
Collaborator

@DidierRLopes DidierRLopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing. This is perfect @erlandsen-tech !

Thank you a ton, and welcome 🤗

@DidierRLopes DidierRLopes merged commit 8e20d9e into OpenBB-finance:main Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants