Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stocks/dps bug fixes #2614

Merged
merged 6 commits into from
Sep 23, 2022
Merged

stocks/dps bug fixes #2614

merged 6 commits into from
Sep 23, 2022

Conversation

montezdesousa
Copy link
Contributor

Fixes #2606
Fixes #2607
Fixes #2608

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

Copy link
Contributor

@simmonsj330 simmonsj330 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@montezdesousa montezdesousa marked this pull request as ready for review September 23, 2022 17:16
@montezdesousa montezdesousa merged commit 593bcf8 into main Sep 23, 2022
@montezdesousa montezdesousa deleted the dps_fixes branch September 23, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
2 participants