Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New path for portfolio data #2611

Merged
merged 18 commits into from
Sep 26, 2022
Merged

New path for portfolio data #2611

merged 18 commits into from
Sep 26, 2022

Conversation

soggyomelette
Copy link
Contributor

Description

New path for portfolio data outside the terminal

@soggyomelette soggyomelette added the feat XS Extra small feature label Sep 23, 2022
Copy link
Contributor

@Chavithra Chavithra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Would just remove the copy_files.

@minhhoang1023
Copy link
Contributor

@JerBouma Can you give this a try to see if it all works as expected?

@soggyomelette
Copy link
Contributor Author

We could also look at deprecating the pa menu since it doesn't seem to be used by the portfolio base controller

@soggyomelette soggyomelette merged commit 5a3a9f9 into main Sep 26, 2022
@Chavithra Chavithra deleted the new_path_portfolio_data branch October 17, 2022 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants