Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portfolio controller fixes #2610

Merged
merged 7 commits into from
Sep 23, 2022
Merged

Portfolio controller fixes #2610

merged 7 commits into from
Sep 23, 2022

Conversation

montezdesousa
Copy link
Contributor

@montezdesousa montezdesousa commented Sep 23, 2022

Description

Fixes #2600
Fixes #2597
Fixes #2596
Fixes #2604

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@montezdesousa montezdesousa added bug Fix bug portfolio Portfolio menu labels Sep 23, 2022
@montezdesousa montezdesousa marked this pull request as ready for review September 23, 2022 10:35
@minhhoang1023 minhhoang1023 merged commit 7a02f85 into main Sep 23, 2022
@minhhoang1023 minhhoang1023 deleted the portfolio_fixes branch September 23, 2022 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment