Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fresh reports fix #2570

Merged
merged 290 commits into from
Sep 23, 2022
Merged

fresh reports fix #2570

merged 290 commits into from
Sep 23, 2022

Conversation

soggyomelette
Copy link
Contributor

Description

Fresh PR for reports installer fix as previous didn't merge correctly

montezdesousa and others added 30 commits August 23, 2022 14:05
@montezdesousa
merge API factory
5d81cf2
@montezdesousa
Merge branch 'api_next' of github.com:OpenBB-finance/OpenBBTerminal i…
ddcb2e5 
…nto api_next
@montezdesousa
add helpers, stocks, crypto, forex
7f07f25
@soggyomelette
minor forex changes
f824e72
@montezdesousa
include forex api paths
5577f8f
@montezdesousa
add 2 missing forex funcs
3268ae6
@soggyomelette
portfolio brokers refactor
4354859
@montezdesousa
display help on api func call
d29ef87
@montezdesousa
Merge branch 'api_next' of github.com:OpenBB-finance/OpenBBTerminal i…
9f11cc5 
…nto api_next
@montezdesousa
add econometrics virtual paths to api
dcbaf01
@montezdesousa
add api unit test
637e3af
@hjoaquim
fixed report for the new api
c1478f7
@hjoaquim
Merge branch 'api_next' of github.com:OpenBB-finance/OpenBBTerminal i…
e49e15b 
…nto api_next
@soggyomelette
minor portfolio refactorings
ce3f7e0
@soggyomelette
added gdapps
a5b4ce5
@soggyomelette
anchor_yield path
ef125b9
@soggyomelette
some more crypto path fixes
2444397
@soggyomelette
small change
3fec2c0
@hjoaquim
fixed wrong param
0e3bcf4
@hjoaquim
minor fixes
6fb5dce
@hjoaquim
Merge branch 'api_next' of github.com:OpenBB-finance/OpenBBTerminal i…
58a385c 
…nto api_next
@hjoaquim
wip - inital commit for forex report
8ae74f5
@minhhoang1023
Merge branch 'main' into api_next
fb33706
@montezdesousa
add bw as a model, we'll get better solution afterwards
e1e1d50
@montezdesousa
Merge branch 'api_next' of github.com:OpenBB-finance/OpenBBTerminal i…
af35f91 
…nto api_next
@hjoaquim
added ema with dummy model as it adds great functionality to the report
58dac79
@hjoaquim
minor fixes
02fd16b
@hjoaquim
wip - added functions to forex report
1ef7f14
@montezdesousa
add feedparser news path
8e5389a
@montezdesousa
Merge branch 'api_next' of github.com:OpenBB-finance/OpenBBTerminal i…
2e9ad04 
…nto api_next
@soggyomelette soggyomelette added bug Fix bug feat S Small T-Shirt size Feature labels Sep 20, 2022
@piiq
Copy link
Contributor

piiq commented Sep 20, 2022

on my machine when I run the report all the charts pop up on screen and. stay there

@soggyomelette
Copy link
Contributor Author

on my machine when I run the report all the charts pop up on screen and. stay there

I think that's a consequence of how the functions are written - for example, quote prints the rich table in its model so we would have to refactor how it functions to prevent the charts from showing on the command line

@soggyomelette soggyomelette changed the base branch from api_next to main September 20, 2022 14:08
@soggyomelette soggyomelette changed the base branch from main to api_next September 20, 2022 14:08
@Chavithra Chavithra changed the base branch from api_next to main September 20, 2022 14:15
@soggyomelette soggyomelette changed the base branch from main to api_next September 20, 2022 14:16
@piiq piiq mentioned this pull request Sep 20, 2022
Closed
@Chavithra Chavithra changed the base branch from api_next to main September 20, 2022 16:13
@soggyomelette soggyomelette added the do not merge Label to prevent pull request merge label Sep 21, 2022
@soggyomelette
Copy link
Contributor Author

Charts in terminal don't show up after a report is run - not able to identify the issue so far

@soggyomelette soggyomelette removed the do not merge Label to prevent pull request merge label Sep 23, 2022
@soggyomelette
Copy link
Contributor Author

At the moment, the issue is with the bt module switching to a non-interactive plotting backend but attempts to switch back don't seem to work. So, as a temporary fix, the bt module is not available to use from the api but whenever a fix is identified, it will be modified in a future PR

Chavithra
Chavithra approved these changes Sep 23, 2022
View reviewed changes
Copy link
Contributor

@Chavithra Chavithra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@soggyomelette soggyomelette merged commit 8e3760a into main Sep 23, 2022
@piiq piiq deleted the fixreports branch September 23, 2022 13:30
@minhhoang1023 minhhoang1023 mentioned this pull request Sep 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piiq piiq piiq approved these changes

@Chavithra Chavithra Chavithra approved these changes

Assignees
No one assigned
Labels
bug Fix bug feat S Small T-Shirt size Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@soggyomelette @piiq @Chavithra @montezdesousa @hjoaquim @minhhoang1023 @JerBouma @colin99d @northern-64bit