Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug and refactor stock helpers #2566

Merged
merged 9 commits into from
Sep 23, 2022
Merged

Fix a bug and refactor stock helpers #2566

merged 9 commits into from
Sep 23, 2022

Conversation

colin99d
Copy link
Contributor

@colin99d colin99d commented Sep 20, 2022

Description

Fixes #2474 and breaks up the massive load function a little bit.

How has this been tested?

  • Pytest passed
  • Linters passed
  • Ran commands that were changed in API (stocks.load and stocks.search)
  • Ran applicable integrated tests

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@colin99d colin99d added the bug Fix bug label Sep 20, 2022
@colin99d colin99d added the do not merge Label to prevent pull request merge label Sep 23, 2022
@colin99d colin99d removed the do not merge Label to prevent pull request merge label Sep 23, 2022
@@ -1226,7 +1226,7 @@ def call_fib(self, other_args: List[str]):
custom_indicators_view.fibonacci_retracement(
symbol=self.coin,
data=self.stock,
period=ns_parser.period,
limit=ns_parser.period,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isnt limit for showing a certain number of dataframe entries

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it was extended for this as well. The function had already been changed,

@colin99d colin99d merged commit 197c08e into main Sep 23, 2022
@colin99d colin99d deleted the fix_perf branch September 23, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]Stock Load producers incorrect changes over time
2 participants