Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding warning to news #2545

Merged
merged 2 commits into from
Sep 15, 2022
Merged

adding warning to news #2545

merged 2 commits into from
Sep 15, 2022

Conversation

simmonsj330
Copy link
Contributor

Description

News seems to have a bug only when DOWNLOADING the installer. This adds notification to users if it fails.

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@simmonsj330 simmonsj330 added the bug Fix bug label Sep 14, 2022
@simmonsj330 simmonsj330 self-assigned this Sep 14, 2022
@piiq piiq merged commit fbdf6e7 into OpenBB-finance:main Sep 15, 2022
@simmonsj330 simmonsj330 deleted the another_news_branch branch September 22, 2022 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piiq piiq piiq approved these changes

Assignees

@simmonsj330 simmonsj330

Labels
bug Fix bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simmonsj330 @piiq @colin99d