Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patching news command #2530

Merged
merged 2 commits into from
Sep 13, 2022
Merged

Conversation

simmonsj330
Copy link
Contributor

@simmonsj330 simmonsj330 commented Sep 12, 2022

Description

News command does not run every time. This patches it by making the command run until either data is returned from feedparser or it hits a timeout.

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@simmonsj330 simmonsj330 added the bug Fix bug label Sep 12, 2022
@simmonsj330 simmonsj330 self-assigned this Sep 12, 2022
@simmonsj330 simmonsj330 merged commit 43dd40a into OpenBB-finance:main Sep 13, 2022
@simmonsj330 simmonsj330 deleted the news_bug_times3 branch September 13, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants