Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/1.8.0 #2521

Merged
merged 6 commits into from
Sep 9, 2022
Merged

Release/1.8.0 #2521

merged 6 commits into from
Sep 9, 2022

Conversation

simmonsj330
Copy link
Contributor

Description

Release 1.8.0

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

simmonsj330 and others added 5 commits September 7, 2022 13:42
@simmonsj330
Update pyproject.toml
99e31c1
@simmonsj330
Update setup.nsi
d5fa80b
@simmonsj330
Update feature_flags.py
3b2d142
@simmonsj330 @piiq
M1 macos build system (#2504) (#2514)
58687fa 
* Create m1_macos_build.yml

* Update m1_macos_build.yml

* Update m1_macos_build.yml

* Update m1_macos_build.yml

* Update m1_macos_build.yml

* Update m1_macos_build.yml

* Update m1_macos_build.yml

* taking out notarize and staple

includes codesigning tho

* changing prediction install

I am expecting a code sign error instead of a running the actual executable error. trying with -e prediction instead of -e prediction-m1-mac

* Changing prediction, keeping code signing

* Update m1_macos_build.yml

* Update m1_macos_build.yml

* taking out integration tests

* rerun

* Update m1_macos_build.yml

* adding pred back to turn to false

* making same as upstream release

* Update m1_macos_build.yml

* Update m1_macos_build.yml

* Update m1_macos_build.yml

Co-authored-by: Theodore Aptekarev <[email protected]>

Co-authored-by: Theodore Aptekarev <[email protected]>
@simmonsj330
Changing detatch disc location
d2567b2
@simmonsj330 simmonsj330 added the build Build-related work label Sep 8, 2022
@simmonsj330 simmonsj330 self-assigned this Sep 8, 2022
@simmonsj330 simmonsj330 merged commit 10fce6d into main Sep 9, 2022
@simmonsj330 simmonsj330 deleted the release/1.8.0 branch September 12, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmaslek jmaslek jmaslek approved these changes

@minhhoang1023 minhhoang1023 Awaiting requested review from minhhoang1023

Assignees

@simmonsj330 simmonsj330

Labels
build Build-related work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simmonsj330 @jmaslek