Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intel installer bug fix #2505

Merged
merged 9 commits into from
Sep 6, 2022
Merged

Intel installer bug fix #2505

merged 9 commits into from
Sep 6, 2022

Conversation

simmonsj330
Copy link
Contributor

@simmonsj330 simmonsj330 commented Sep 5, 2022

Description

Fixes #2320 by adding entitlements file to sidestep hardened runtime errors on certain OSX versions.

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@simmonsj330 simmonsj330 added the build Build-related work label Sep 5, 2022
@simmonsj330 simmonsj330 self-assigned this Sep 5, 2022
@minhhoang1023
Copy link
Contributor

I was able to reproduce the problems, and with this new version, it's working well!

It's better to have @Chavithra review the code instead of me, as I haven't been deeply involved with the installer.

@simmonsj330 simmonsj330 merged commit 926cf0c into main Sep 6, 2022
@simmonsj330 simmonsj330 deleted the intel_installer_bug_fix branch September 14, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build-related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] The application does not start for the first time
3 participants