Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add End of Day Historical Data to FA : https://eodhistoricaldata.com/r/?ref=869U7F4J to #2500

Merged
merged 46 commits into from
Sep 29, 2022

Conversation

pauljsymonds
Copy link
Contributor

Description

  • Implementation of fa, Initial fundamentals added:

  • Income,

  • Balance,

  • Cash

  • with Ratios and Plots for eodhd premium source

  • This must be tested with the key - demo
  • Demo key only works with AAPL

@DidierRLopes @colin99d please check this out and provide feedback.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

pauljsymonds and others added 30 commits June 29, 2022 23:31
@colin99d colin99d self-requested a review September 5, 2022 10:51
@colin99d
Copy link
Contributor

colin99d commented Sep 5, 2022

Looks great Paul! Only change I need is that adding the limit argument does not change the amount of output.

@pauljsymonds
Copy link
Contributor Author

Looks great Paul! Only change I need is that adding the limit argument does not change the amount of output.

That limit argument is specifically for ratios only as that was the slow part, the rest should return as normal all data.

Let me know how you would prefer it to work. For certain though Ratios cannot work for much more than that.

@colin99d colin99d added the enhancement Enhancement label Sep 5, 2022
@colin99d colin99d merged commit 769ae75 into OpenBB-finance:main Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants