Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CONTRIBUTING GUIDELINES #2494

Merged
merged 95 commits into from
Sep 26, 2022
Merged

Refactor CONTRIBUTING GUIDELINES #2494

merged 95 commits into from
Sep 26, 2022

Conversation

DidierRLopes
Copy link
Collaborator

This will provide a big improvement in our current Contributing guidelines

@DidierRLopes DidierRLopes added the feat S Small T-Shirt size Feature label Sep 4, 2022
@colin99d colin99d self-requested a review September 5, 2022 07:27
@montezdesousa montezdesousa added the do not merge Label to prevent pull request merge label Sep 14, 2022
@montezdesousa
Copy link
Contributor

I'll be adding terminal code guide here. Pls don't merge just yet

@DidierRLopes
Copy link
Collaborator Author

Thanks @montezdesousa! This is starting to look very nice! I can't approve this PR because I created it, but @minhhoang1023 feel free to approve it when you think is good :)

@DidierRLopes DidierRLopes marked this pull request as ready for review September 23, 2022 23:46
@piiq
Copy link
Contributor

piiq commented Sep 25, 2022

@minhhoang1023's change request is blocking me from merging. Is there anything else required here?

@minhhoang1023
Copy link
Contributor

@piiq The logging section is currently empty. Once @Chavithra adds it, lgtm for merging

@montezdesousa montezdesousa merged commit 1f85ae2 into main Sep 26, 2022
@minhhoang1023 minhhoang1023 deleted the contribute branch September 26, 2022 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat S Small T-Shirt size Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants