refactor: convert for loops into list and dict comprehensions

[Uzaaft]

Description

The aim of this PR is to refactor all possible for-loops where lists and dicts are created into list-comprehensions, to get an easy gain of performance.

How has this been tested?

The list-comprehensions does not add any additional logic, it just required a rewrite of the old logic. If tests passed before, they will(and does locally), pass.

• Provide instructions so we can reproduce.
• Please also list any relevant details for your test configuration.

Checklist:

None of these are required since this is just a refactor

• Update our Hugo documentation following these guidelines.
• Update our tests following these guidelines.
• Make sure you are following our CONTRIBUTING guidelines.
• If a feature was added make sure to add it to the corresponding scripts file.

Others

• I have performed a self-review of my own code.
• I have commented my code, particularly in hard-to-understand areas.
• My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
• New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

[Uzaaft]

Regarding this:
Why is this here at all? This causes the flake8 lint to fail

[Uzaaft]

The variable new_datasets is not being used later on after the if-test

[Uzaaft]

@DidierRLopes Do you know?
I'm inclined towards moving the unused variable. There seems to be no usage of it in the code.

[DidierRLopes]

This was done by @JerBouma, probably he can shed some insight here

[Uzaaft]

I think a lot of these will come forward as I open PR's for the different refactors btw. 😅

[Uzaaft]

Thanks a lot @JerBouma!
@DidierRLopes Perhaps, going forward, if a variable is unused, should we just go ahead and remove it? Unless anything else is explicitly mentioned on the code?

[piiq]

@Uzaaft yes, definitely unused variables should not be in the code. I wonder how that one passed the linters.

Would you be up for jumping into a call on Discord or elsewhere to coordinate the contributing efforts? This would make it easier and quicker to merge PRs

[Uzaaft]

Yeah sure thing @piiq.
After the merging that you did, I saw a few more possibilities of using list-comprehensions, so I am including those as well now.

[piiq]

@Uzaaft can you add me on discord please? pll_llq#8920

[Uzaaft]

I just sent you an request @piiq

[Uzaaft]

@piiq All checks passed , but I need to update the branch once again😂

[piiq]

🚀

[Uzaaft]

On to the Next one🤓