Improve ux experience through auto completer

[DidierRLopes]

Give it a go

[deeleeramone]

/economy/index after the first index is selected, autocomplete wants to add a second index to the chart when the - is entered after the first choice.

Using the -i flag under /economy/index brings up choices that should be activated after space is entered in the command string as opposed to immediately being triggered by the single dash.

Also noteworthy is that double-dashes do not present any choices.

[DidierRLopes]

/economy/index after the first index is selected, autocomplete wants to add a second index to the chart when the - is entered after the first choice.

Using the -i flag under /economy/index brings up choices that should be activated after space is entered in the command string as opposed to immediately being triggered by the single dash.

Also noteworthy is that double-dashes do not present any choices.

I only tested the macro economy. Will look into what's going on here. Thanks!

[DidierRLopes]

/economy/index after the first index is selected, autocomplete wants to add a second index to the chart when the - is entered after the first choice.

Using the -i flag under /economy/index brings up choices that should be activated after space is entered in the command string as opposed to immediately being triggered by the single dash.

Also noteworthy is that double-dashes do not present any choices.

Notes:

The index only had autocomplete for "index WORD" hence why there are no "--" and "-" args autocompleters - the behaviour is the same.

This auto-completer is designed to need a "--" flag to proceed to autocomplete, hence why results are sucky with "-". Having both would increase time by 2x, so we will only support an autocomplete for one.

[deeleeramone]

This auto-completer is designed to need a "--" flag to proceed to autocomplete, hence why results are sucky with "-". Having both would increase time by 2x, so we will only support an autocomplete for one.

By this, do you mean that autocomplete will support only "--", and not "-"?

[DidierRLopes]

This auto-completer is designed to need a "--" flag to proceed to autocomplete, hence why results are sucky with "-". Having both would increase time by 2x, so we will only support an autocomplete for one.

By this, do you mean that autocomplete will support only "--", and not "-"?

Likely yes. The reason being for performance (speed), not because we can't make it happen :)

[DidierRLopes]

@deeleeramone try it out now. I fixed the entire menu to have autocomplete for "--".

@jmaslek @piiq check the implementation on the economy menu if u have some time

[deeleeramone]

It seems to work, but with a caveat being after the first command is run, the functions in the menu no longer trigger autocomplete. so, if you run overview once, the menu has the functions autocomplete, but the second time it does not and is only triggered when -- is deployed.

This is more of a blocker than above, @DidierRLopes: map --type brings up the choices only for overview --type.

[DidierRLopes]

It seems to work, but with a caveat being after the first command is run, the functions in the menu no longer trigger autocomplete. so, if you run overview once, the menu has the functions autocomplete, but the second time it does not and is only triggered when -- is deployed.

This is more of a blocker than above, @DidierRLopes: map --type brings up the choices only for overview --type.

Very nice catch. This is not easy to trigger, it happens when you delete the command that you had first input, I am going to fix this - thanks for spotting it.

[DidierRLopes]

@deeleeramone both those cases where caused by the fact of you going back and changing first argument, I didn't account for that behaviour.

It should now be taken care of. Let me know if it works well now!

[jmaslek]

This is definitely a sweet improvement.

Is a little buggy. This behavior changed at some point. Seems to be when i was in the middle of a completer than I do a backspace. (Confirms this happens when backspacing)

Also if I start to type, the autocompleter doesnt know where I am in the list.

[deeleeramone]

industry shows as a choice for a function and not an argument.

bigmac --country doesn't populate with countries, and instead presents column names as choices.

ycrv --country is not able to handle the spaces where a country name is two words.

[DidierRLopes]

This is definitely a sweet improvement.

Is a little buggy. This behavior changed at some point. Seems to be when i was in the middle of a completer than I do a backspace. (Confirms this happens when backspacing)

Also if I start to type, the autocompleter doesnt know where I am in the list.

This is with my last change, messed up that end. Will look into this.

[DidierRLopes]

@jmaslek and @deeleeramone . Both should be fixed now!

[DidierRLopes]

This is as good as it gets if not even @deeleeramone can find any issue