Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redact inception date from investpy when incorrect #2482

Merged
merged 5 commits into from
Sep 4, 2022
Merged

redact inception date from investpy when incorrect #2482

merged 5 commits into from
Sep 4, 2022

Conversation

sandsmichael
Copy link
Contributor

Description

How has this been tested?

Locally on my machine

  • Please describe the tests that you ran to verify your changes.
    Replicated original bug report steps with different funds.
  • Provide instructions so we can reproduce.

funds
load gtapx
info

  • Please also list any relevant details for your test configuration.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@sandsmichael
Copy link
Contributor Author

#2469

@sandsmichael
Copy link
Contributor Author

@jmaslek @deeleeramone Any tips on adding a label to this PR to pass the tests? Not seeing anything in the readme guide.

@sandsmichael sandsmichael reopened this Sep 2, 2022
@deeleeramone deeleeramone added the bug Fix bug label Sep 2, 2022
@jmaslek
Copy link
Collaborator

jmaslek commented Sep 2, 2022

Not a fan of the nan. Maybe lets replace with a "-"

Screen Shot 2022-09-02 at 4 31 04 PM

@DidierRLopes
Copy link
Collaborator

Thank you @sandsmichael !!

@DidierRLopes DidierRLopes merged commit 3c858fc into OpenBB-finance:main Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants