Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix etf function get_all_names_symbols #2467

Merged
merged 5 commits into from
Aug 30, 2022
Merged

Fix etf function get_all_names_symbols #2467

merged 5 commits into from
Aug 30, 2022

Conversation

montezdesousa
Copy link
Contributor

Description

This PR fixes a bug highlighted in #2452.

Function api.etf.models.stockanalysis.get_all_names_symbols() was not retrieving the lists of symbols and names.

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

Copy link
Contributor

@hjoaquim hjoaquim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solves the scrapping issue. Also, all tests pass.
Nicely done!

@hjoaquim hjoaquim merged commit 7df711d into main Aug 30, 2022
@hjoaquim hjoaquim deleted the etf_symbols branch August 30, 2022 23:00
@hjoaquim
Copy link
Contributor

@DidierRLopes @montezdesousa PR merged, but we still need to create an updated image, right? (Regarding #2452)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants