Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve exit message #2448

Merged
merged 4 commits into from
Aug 29, 2022
Merged

improve exit message #2448

merged 4 commits into from
Aug 29, 2022

Conversation

DidierRLopes
Copy link
Collaborator

Notice the "the" 😜

image

@DidierRLopes DidierRLopes added the docs Code documentation label Aug 29, 2022
"show your appreciation on [cmds]https://twitter.com/openbb_finance[/cmds],\n"
"ask support on [cmds]https://openbb.co/support[/cmds], "
"or even request a feature on [cmds]https://openbb.co/request-a-feature[/cmds]\n"
"[param]OpenBB Terminal is the result of a strong community building an "
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*the :P

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check my new commit 🤣

Copy link
Collaborator

@jmaslek jmaslek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

u are an exit message

@JerBouma
Copy link
Contributor

Wouldn't it be better to add a generic recruiting message? If people now continue to use this version of the terminal, they constantly see there is a vacancy open for UI/UX while perhaps in a week or two it isn't there anymore.

@DidierRLopes
Copy link
Collaborator Author

@JerBouma good point, just updated to reflect that

@DidierRLopes DidierRLopes merged commit 464b6a1 into main Aug 29, 2022
@Chavithra Chavithra deleted the advertise branch September 20, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Code documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants